Re: diff-yank-handler is evil

[Stefan Monnier]

>>> Leading '+', '!' and '-' are stripped -- it's no longer a valid diff
>>> after yanking.  It's not useful to send someone a bogus diff.
>> Please give us an example.
> Enable font-lock.  Place the following in a buffer in diff-mode:

> diff -c /home/harder/t1.txt /home/harder/t2.txt
> *** /home/harder/t1.txt       Wed Mar 24 21:34:50 2004
> --- /home/harder/t2.txt       Wed Mar 24 21:35:07 2004
> ***************
> *** 1,4 ****
> ! Foo.
>   Bar.
  
>   Bla bla bla.
> --- 1,4 ----
> ! FOO.
>   Bar.
  
>   Bla bla bla.
> ***************
> *** 6,8 ****
> --- 6,9 ----
>   Bla bla bla.
  
  
> + Baz.

> Diff finished.  Wed Mar 24 21:35:12 2004

Thanks.

> Come on, "missing !'s when pasting" is pretty specific.  Besides, this
> behaviour was so easy to trigger, that I didn't think you'd need a
> verbose 140 line bug-report to reproduce it.

Do you really think I'd bother to bitch if I hadn't tried it first (and
failed to create the problem)?

OK, I see that a change to subr.el's yank-handler code broke
diff-yank-handler about 90% (and I only use the remaining 10%).

I don't see how to fix it with the new yank-handler behavior, so I'll
disable it for now.


        Stefan