Re: *cvs-commit* gets used as PCVS buffer

[Stefan Monnier]

>>>>> "David" == David Kastrup <address@hidden> writes:

> This bug report will be sent to the Free Software Foundation,
> not to your local site managers!
> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.

> Your bug report will be posted to the address@hidden mailing list.

> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:

> If you do something like
> M-x cvs-examine RET /home/tmp/emacs RET
> go on one line, then use
> C-u C
> to get a Log edit buffer, then do a kill-buffer of the original *cvs*
> buffer, switch to some arbitrary buffer and do
> M-x cvs-examine RET /home/tmp/emacs RET
> again, then the *cvs-commit* buffer will get "reused" as the main PCVS
> buffer.  Since this usage conflicts when you are doing another commit,
> PCVS can get rather confused.

Ahh... I think I finally got it.  Does the patch below fix the problem?
I believe it should.  The only problem is that I can't figure out what this
code was supposed to do, so it may break something.


        Stefan


--- pcvs.el     02 mai 2005 11:41:42 -0400      1.80
+++ pcvs.el     04 mai 2005 13:44:29 -0400      
@@ -1438,12 +1438,10 @@
   ;; displayed in the wrong minibuffer).
   (cvs-mode!)
   (let ((buf (cvs-temp-buffer "message" 'normal 'nosetup))
-       (lbd list-buffers-directory)
        (setupfun (or (nth 2 (cdr (assoc "message" cvs-buffer-name-alist)))
                      'log-edit)))
     (funcall setupfun 'cvs-do-commit setup 'cvs-commit-filelist buf)
     (set (make-local-variable 'cvs-minor-wrap-function) 'cvs-commit-minor-wrap)
-    (set (make-local-variable 'list-buffers-directory) lbd)
     (run-hooks 'cvs-mode-commit-hook)))
 
 (defun cvs-commit-minor-wrap (buf f)
@@ -1494,14 +1492,12 @@
   ;; displayed in the wrong minibuffer).
   (cvs-mode!)
   (let ((buf (cvs-temp-buffer "message" 'normal 'nosetup))
-       (lbd list-buffers-directory)
        (setupfun (or (nth 2 (cdr (assoc "message" cvs-buffer-name-alist)))
                      'log-edit)))
     (funcall setupfun 'cvs-do-edit-log nil 'cvs-edit-log-filelist buf)
     (when text (erase-buffer) (insert text))
     (set (make-local-variable 'cvs-edit-log-revision) rev)
     (set (make-local-variable 'cvs-minor-wrap-function) 
'cvs-edit-log-minor-wrap)
-    (set (make-local-variable 'list-buffers-directory) lbd)
     ;; (run-hooks 'cvs-mode-commit-hook)
     ))