makefile-mode font-lock bugs and annoyances

[Glenn Morris]

Since it doesn't seem to be going away (despite this thread where
nobody liked it:
<http://lists.gnu.org/archive/html/emacs-devel/2005-05/msg00758.html>;
and several poeple asked for the changes to be reverted), here is a
list of problems with the latest makefile-mode.


Font-lock bugs:

1. In constructs such as:

ARCH       = $(shell uname -s)

"shell" is highlighted as a variable when it is not. Emacs-21.3 gets
this right.


2. Highlighting of conditional constructs is broken:

ifdef FOO
   blah
else
   blah blah
endif

i) FOO does not get highlighted as a variable. Emacs-21.3 gets this
right.
ii) ifdef / else / endif do not get highlighted as keywords.
Emacs-21.3 gets this right.


Annoyances. These are all IMO.

1. makefile-shell-face is incredibly ugly.

Eg in the following:

   cd $(bindir) ; \
   rm -f $(targets)

I see a spoldge of grey background extending from "cd" through to the
right-hand edge of the display on that line, and from column 0 in the
"rm" line to the end of the text. Yuck. Moreover, I don't think it
serves any useful purpose.


2. With something like:

clean :
      -rm -f *.mod *.o $(targets)

The "-" before "rm" gets highlighted in font-lock-type-face. This is
just silly.


3. $@ gets highlighted with makefile-targets-face. I'd prefer it to be
   treated as a variable, as it used to be, because... it's a
   variable.


4. Ditto for $^, which gets font-lock-constant-face at present.