emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: In info: Wrong type argument: stringp, nil


From: Juri Linkov
Subject: Re: In info: Wrong type argument: stringp, nil
Date: Fri, 06 Jan 2006 14:00:09 +0200
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux)

> I fixed this bug.

I don't understand the purpose of the following fix:

@@ -568,7 +568,9 @@
        (if (and (stringp file-or-node) (string-match "(.*)" file-or-node))
            file-or-node
          (concat "(" file-or-node ")")))
-    (if (zerop (buffer-size))
+    (if (and (zerop (buffer-size))
+            (null Info-history))
+       ;; If we just created the Info buffer, go to the directory.
         (Info-directory))))
 
A new condition `(null Info-history)' doesn't fix a bug, but with some
user configuration it creates an empty Info buffer.

> Does that patch from Nov 25 have any other problem?

I can't produce any problem now, so we could either wait for more bug
reports or at least restore the following change:

@@ -726,8 +729,7 @@
        (pline        (count-lines (point-min) (line-beginning-position)))
        (wline        (count-lines (point-min) (window-start)))
        (old-history  Info-history)
-       (new-history (and Info-current-file
-                         (list Info-current-file Info-current-node (point)))))
+       (new-history  (list Info-current-file Info-current-node (point))))
     (kill-buffer (current-buffer))
     (Info-find-node filename nodename)
     (setq Info-history old-history)

This change most likely can produce a bug because a condition below in
the same function tests the value of `new-history' as:

      ;; only add to the history when coming from a different file+node
      (if new-history
          (setq Info-history (cons new-history Info-history))))))

-- 
Juri Linkov
http://www.jurta.org/emacs/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]