Re: build process tried to build xmenu.c when it couldn't find X Windows headers

[Chris Moore]

Yes, you're right.  I wrote the email as I was investigating what was going on and forgot to fix the subject later.

Incidentally, I would suggest that the person who needs to look at this is the one who knows about autoconf, rather than knowing about GTK.  The problem is with 
configure.in and how it claims that --with-gtk is the same as --with-x-toolkit=gtk, but then goes on to treat them differently.

The following patch fixes the problem, causing the --with-gtk flag to be ignored in the event that the X11 headers can't be found:

-----------------------------------------------------------
--- Backup/configure.in.~1~    2006-01-08 19:34:54.000000000 +0100
+++ configure.in    2006-01-08 23:47:46.000000000
 +0100
@@ -1724,6 +1724,7 @@
     HAVE_X_WINDOWS=no
     HAVE_X11=no
     USE_X_TOOLKIT=none
+    with_gtk=no
   ;;
 esac
 
-----------------------------------------------------------

Chris.

On 1/8/06, Eli Zaretskii <address@hidden> wrote:

> Date: Sun, 8 Jan 2006 22:04:23 +0100
> From: Chris Moore <address@hidden>
>
> I just tried building Emacs and it failed.  I didn't have the X headers
> installed, but I asked it to use the GTK toolkit.

Thanks for the report.  Someone who knows about GTK more than I will
look into this, but in the meanwhile I'd like you to know that the
fact xmenu.c is compiled without X headers is not a bug.  This is how
Emacs build is supposed to work.  (Your Subject line sounds like you
think xmenu.c should not have been compiled without X headers, which
isn't true.)