emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HTTP redirects make url-retrieve-synchronously asynchronous


From: Mark Plaksin
Subject: Re: HTTP redirects make url-retrieve-synchronously asynchronous
Date: Thu, 19 Jan 2006 17:46:27 -0500
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.51 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> It might not be elegant but the attached patch works for me.  If
>> url-retrieve sees :redirect in cbargs, it calls url-retrieve-synchronously
>> and then calls the callback with cbargs.
>
> That wasn't what the attached patch did, but in any case that'd be
> a workaround, not a fix.

The more I think about it the more my patch seems like an OK fix instead of
a workaround.  What makes it a workaround to you?

My fix is short and simple and preserves the synchronicity of the original
call.  That is, if url-retrieve encountered the redirect, it will remain
asynchronous; if url-retrieve-synchronously encountered the redirect it
remains synchronous.

Also, it seems like RMS (who added :redirect) might have been thinking that
url-retrieve should do something special with redirects.  Here's the
ChangeLog entry corresponding to RMS' change:

  2005-07-15  Richard M. Stallman  <address@hidden>
  
  * url-http.el (url-http-parse-headers): Add :redirect arg-pair
  when calling url-retrieve, to indicate a redirect.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]