emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: shouldn't Fsignal be marked NORETURN?


From: Nick Roberts
Subject: Re: shouldn't Fsignal be marked NORETURN?
Date: Sun, 9 Apr 2006 22:17:13 +0100 (BST)

 > How about wrong_type_argument ? It looks like there's some dead code
 > in there, but it has not been touched in ages.

That might be a good reason not to touch it now.

 > Also it seems that the while (1) can be deleted from args_out_of_range
 > and args_out_of_range_3.

If your analysis is right then deleting it will remove some dead code, but if
its wrong then maybe you're introducing a bug.  These aren't bugs in the usual
sense of the word: they don't necessarily break Emacs.  If Emacs was safety
critical software it might be important to deal with them now.  But its not,
so this drags just things out for longer, possibly introducing new bugs which
will drag things out for even longer...


-- 
Nick                                           http://www.inet.net.nz/~nickrob




reply via email to

[Prev in Thread] Current Thread [Next in Thread]