emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Error in matcher for 'gnu' errors in compile.el


From: Tim Van Holder
Subject: Error in matcher for 'gnu' errors in compile.el
Date: Mon, 24 Apr 2006 14:43:32 +0200

The "gnu" error matcher in compile has a bug: it includes a matcher for an
optional DOS-style drive specifier as part of the filename pattern:
  \\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\)
However because only the colon is optional, this imposes a requirement on the
filename that its first component start with an (ASCII) alphabetic character;
this does not match paths such as "../1-parsing/sample.c".
The patch below resolves the problem by making the entire drivespec optional,
instead of only the colon.  It also places it at the front (../a:xxx/ is not
a valid filename).


In GNU Emacs 22.0.50.2 (i686-pc-linux-gnu, GTK+ Version 2.8.16)
 of 2006-04-24 on leeloo
X server distributor `RealVNC Ltd', version 11.0.3370
configured using `configure '--with-gtk' '--with-xpm' '--with-jpeg' 
'--with-gif' '--with-tiff' '--with-png' '--with-x' '--with-kerberos' 
'--with-kerberos5''


--- lisp/progmodes/compile.el   03 Apr 2006 08:08:51 +0200      1.394
+++ lisp/progmodes/compile.el   24 Apr 2006 14:33:16 +0200      
@@ -224,7 +224,7 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?
 
     (gnu
      "^\\(?:[[:alpha:]][-[:alnum:].]+: ?\\)?\
-\\([/.]*[a-zA-Z]:?[^ \t\n:]*\\|{standard input}\\): ?\
+\\(\\(?:[a-zA-Z]:\\)?[/.]*[^ \t\n:]*\\|{standard input}\\): ?\
 \\([0-9]+\\)\\([.:]?\\)\\([0-9]+\\)?\
 \\(?:-\\(?:\\([0-9]+\\)\\3\\)?\\.?\\([0-9]+\\)?\\)?:\
 \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\




reply via email to

[Prev in Thread] Current Thread [Next in Thread]