RE: Compile-goto-error can signal wrong-type-argument

[Marshall, Simon]

Hi Stefan, thanks for the response.

I had to apply the patch by hand, since I've been away and the patch was
against an older revision that the one I now have post-update.

I have only used this feature with popup windows, and the patch doesn't make
any difference to me with those.  I'm using the MOTIF toolkit.  I am still
able to click on the OK button even when in a directory that does not
contain the file.

Looking into it, maybe it is because x-file-dialog does not support
PREDICATE?  Or am I misreading code?

Simon.

> -----Original Message-----
> From: Stefan Monnier [mailto:address@hidden 
> Sent: 11 July 2006 15:21
> To: Marshall, Simon
> Cc: 'Emacs Pretest Bug (address@hidden)'
> Subject: Re: Compile-goto-error can signal wrong-type-argument
> 
> >>>>> "Marshall," == Marshall, Simon 
> <address@hidden> writes:
> 
> > This is a buggette in CVS head as of 2006-06-19.
> > src/emacs -Q
> > Start a compilation which is going to raise some errors.  
> Then mouse-1 
> > on an error to get the popup window "Find this error in 
> (default ...)" 
> > for you to navigate to the file.  (The error message 
> doesn't contain 
> > enough info for Emacs to be able to work it out itself.)  
> So far, so good.
> 
> > In the popup, navigate to the wrong directory and click on 
> OK without 
> > going through the process of finding the file entry and 
> selecting it 
> > first.  (You can't - you're in the wrong directory!)
> 
> Does the patch below give a cleaner behavior (it should 
> prevent you from selecting a directory in which the file 
> doesn't exist).