emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: Unused variable in mouse.el: make-cursor-line-fully-visible


From: Drew Adams
Subject: RE: Unused variable in mouse.el: make-cursor-line-fully-visible
Date: Sat, 27 Jan 2007 09:22:01 -0800

Also, there are multiple functions defined in mouse.el that have no doc
strings. Some even have no comments that could substitute for doc strings.

I think the mouse.el code could use a bit of cleaning up, generally.

> From: Drew Adams Sent: Saturday, January 27, 2007 9:15 AM
> Here's another unused binding, also in `mouse-drag-track'. It
> seems that this code is called only for its side effect. Is there
> a reason to bind the result? If so, perhaps add a comment
> indicating the reason.
>
>  (_ (mouse-set-point start-event)) ; variable `_' is unused, AFAICT.
>
> Also, the code for `mouse-drag-track' is not indented correctly.
> Please use `M-q' on it. See, e.g., this code starting at line 1043:
>
> (when (and (functionp fun)
> (= start-hscroll (window-hscroll start-window))
> (or end-point ...
>
> > From: Drew Adams Sent: Saturday, January 27, 2007 9:01 AM
> > mouse.el has this binding in `mouse-drag-track':
> >
> >  (make-cursor-line-fully-visible nil)
> >
> > That variable is not used anywhere in the Lisp source code.
> >
> >
> > In GNU Emacs 22.0.93.1 (i386-mingw-nt5.1.2600)
> >  of 2007-01-25 on LENNART-69DE564
> > X server distributor `Microsoft Corp.', version 5.1.2600
> > configured using `configure --with-gcc (3.4) --cflags -Ic:/g/include'
> >
> > Important settings:
> >   value of $LC_ALL: nil
> >   value of $LC_COLLATE: nil
> >   value of $LC_CTYPE: nil
> >   value of $LC_MESSAGES: nil
> >   value of $LC_MONETARY: nil
> >   value of $LC_NUMERIC: nil
> >   value of $LC_TIME: nil
> >   value of $LANG: ENU
> >   locale-coding-system: cp1252
> >   default-enable-multibyte-characters: t
> >
> > Major mode: Dired by name
> >
> > Minor modes in effect:
> >   encoded-kbd-mode: t
> >   tooltip-mode: t
> >   tool-bar-mode: t
> >   mouse-wheel-mode: t
> >   menu-bar-mode: t
> >   file-name-shadow-mode: t
> >   global-font-lock-mode: t
> >   font-lock-mode: t
> >   blink-cursor-mode: t
> >   unify-8859-on-encoding-mode: t
> >   utf-translate-cjk-mode: t
> >   auto-compression-mode: t
> >   line-number-mode: t
> >
> > Recent input:
> > <help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
> > <help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
> > <menu-bar> <help-menu> <report-emacs-bug>
> >
> > Recent messages:
> > (C:\Emacs-22-2007-01-25\bin\emacs.exe -q --no-site-file
> > --debug-init C:\drews-lisp-20)
> > Loading encoded-kb...done
> > For information about the GNU Project and its goals, type C-h C-p.
> > Loading dired...
> > Loading regexp-opt...done
> > Loading dired...done
> > For information about the GNU Project and its goals, type C-h C-p.
> > Loading emacsbug...done
> >





reply via email to

[Prev in Thread] Current Thread [Next in Thread]