[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs.c (main): fix profiling instructions
From: |
Eli Zaretskii |
Subject: |
Re: emacs.c (main): fix profiling instructions |
Date: |
Sun, 01 Apr 2007 06:07:38 +0300 |
> Cc: address@hidden
> From: Markus Triska <address@hidden>
> Date: Sun, 01 Apr 2007 01:10:45 +0200
>
> Eli Zaretskii <address@hidden> writes:
>
> > Why change the flags when running ./configure? Why not simply add
> > LDFLAGS to the `make' command line?
>
> That could inadvertently override options passed to ./configure.
But your suggestion has the same problem, doesn't it? You never told
in your instructions that the profiling options are _in_addition_to_
the others.
> > Doing that at `make' time has the advantage of being correct for the
> > MinGW build as well
>
> The patched line is valid on MinGW as well ("do something like ...").
There's no ``like'', unfortunately.
Anyway, I understand the motivation now, and will install an
appropriate patch. Thanks.