Re: Contiguous redisplay of the menu and beeps

[Chong Yidong]

Chong Yidong <address@hidden> writes:

>> Maybe you need to use specbind for the `current_column' call in
>> redisplay_internal instead.
>>
>> *** src/xdisp.c.~1.1149.2.2.~        Fri May 25 11:00:00 2007
>> --- src/xdisp.c      Sun May 27 22:48:48 2007
>> *************** redisplay_internal (preserve_echo_area)
>> *** 10888,10893 ****
>> --- 10888,10894 ----
>>                       Fcons (make_number (redisplaying_p), selected_frame));
>>     ++redisplaying_p;
>>     specbind (Qinhibit_free_realized_faces, Qnil);
>> +   specbind (Qinhibit_point_motion_hooks, Qt);
>>   
>>     {
>>       Lisp_Object tail, frame;
>>
>> This patch works on Mac OS X for the original problem (without my
>> previous patch).  Adding specbind and unbind_to around the
>> `current_column' in redisplay_internal also works.
>
> For safety, I would prefer to add specbind and unbind_to around the
> `current_column' in redisplay_internal, instead of binding
> Qinhibit_point_motion_hooks for the entirety of redisplay_internal.
>
> If that works, I suggest checking this into just the branch, and
> investigating further after the release.

BTW, as far as I can tell, this is a satisfactory permanent solution,
not just a temporary hack; so we might as well check it into the trunk
too.  However, we may want to overhaul the way column-number-works,
after the release, to avoid problems of this sort.

Thanks.