[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] emms-info-ytdl
From: |
Daniel Semyonov |
Subject: |
Re: [PATCH] emms-info-ytdl |
Date: |
Tue, 10 Dec 2024 00:17:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
>>>>> Yoni Rabkin writes:
> Konstantin <reichcv@gmail.com> writes:
>> Hello,
>>
>> Few years ago Yuchen Pei started to develop emms-info-ytdl (branch
>> info-ytdl), which provides info for links like:
>> https://www.youtube.com/watch?v=.....
>>
>> I do not know why these changes where not accepted in master.
>> Perhaps it is because ytdl is called synchronously, and therefore
>> emms-info-ytdl freezes Emacs.
> You would need to dive into these threads to read the backstory:
> https://lists.gnu.org/archive/html/emms-help/2022-03/msg00035.html
> https://lists.gnu.org/archive/html/emacs-devel/2022-03/msg00754.html
> If the situation has changed in the interim, I'm willing to reconsider
> merging it into Emms.
Using yt-dlp with Invidious or Piped just makes it redirect the requests
to Youtube, and I haven't looked too deep into it but there's still a
JavaScript interpreter included in yt-dlp which is imported by the
Youtube extractor (so it is very likely to still run JavaScript code
locally in order to function).
It's a shame really, as yt-dlp supports many sites other than Youtube,
but obviously using an info method in EMMS should never run non-free
code automatically.
Daniel