[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [WIP PATCH] * emms-volume-mpv.el: New file.
From: |
Yoni Rabkin |
Subject: |
Re: [WIP PATCH] * emms-volume-mpv.el: New file. |
Date: |
Tue, 04 Feb 2025 15:12:35 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Richard Sent <richard@freakingpenguin.com> writes:
> ---
> Hi all,
>
> I've had some annoyances where Emms only supports changing the global
> system volume OOTB when I really want to /just/ change mpv's volume. I
> took a first stab at a patch, but it definitely shouldn't be merged
> since a) emms-volume-mpv-change is a bit ugly and b) I haven't done
> any copyright assignment yet.
>
> I'd appreciate any feedback people have. If you all think this patch
> is worthwhile, I'm happy to complete the appropriate paperwork and
> update the documentation. That being said, the patch is pretty short
> so I understand if we feel it should remain separate.
>
> If this patch isn't the one, hopefully someone can push mpv volume
> adjustment across the finish line. Seems like a "high-demand" feature.
> [1] [2].
>
> Some thoughts:
>
> 1. Should emms-volume-mpv be merged with emms-player-mpv, similar to
> emms-player-mpd? Or should it remain in a separate file?
Ideally, we should wait for the author of emms-player-mpv, Mike
Kazantsev, to weigh in on this.
--
"Cut your own wood and it will warm you twice"
- Re: [WIP PATCH] * emms-volume-mpv.el: New file.,
Yoni Rabkin <=