[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Findutils-patches] patch for #20662 memory leak
From: |
James Youngman |
Subject: |
Re: [Findutils-patches] patch for #20662 memory leak |
Date: |
Sun, 5 Aug 2007 11:34:43 +0100 |
On 8/5/07, Eric Blake <address@hidden> wrote:
>
> OK to commit? Should I port the entire patch back to the branch,
> including the -nowarn and testsuite changes; or just the memory leak fix?
Great patch; thanks! Yes, please commit. I also think it is
worthwhile backporting the whole thing to 4.2.x.
Just one tiny nit...
> + if (strchr(arg, '/') && options.warnings)
Reversing this test will avoid a tiny performance hit for long arguments.
Thanks!
James.