Re: [ft-devel] Broken FT_Face data can cause the infinite loop in FT_Done_Library()

[Werner LEMBERG]

>         while ( faces->head )
>           FT_Done_Face( FT_FACE( faces->head->data ) );
>
> But I wonder if there's any case that the first trial cannot free
> the font data but the second (or later) trial can free it.

Good question.  Currently, I can't imagine such a situation.  David,
do you remember whether this code has been added after experiencing a
real case, or was it just anticipating problems?

> If there's no requirement to repeat FT_Done_Face() for the FT_Face
> data that once failed, I propose to replace
>
>         while ( faces->head )
>           FT_Done_Face( FT_FACE( faces->head->data ) );
>
> by
>
>         if ( faces->head )
>           FT_Done_Face( FT_FACE( faces->head->data ) );

I can't decide this.  Is it possible that such issues arise on systems
with tight memory constraints?

In case you don't see a reply within a week or so, please apply (with
a proper comment).


    Werner