[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Geiser-users] [PATCH] Connecting to a Unix-domain socket
From: |
Ludovic Courtès |
Subject: |
Re: [Geiser-users] [PATCH] Connecting to a Unix-domain socket |
Date: |
Wed, 26 Feb 2014 23:03:22 +0100 |
User-agent: |
Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) |
Hello!
"Jose A. Ortega Ruiz" <address@hidden> skribis:
> On Tue, Feb 18 2014, Ludovic Courtès wrote:
>
>> Hello!
>>
>> The patches below allow Geiser to connect to a Unix-domain socket via
>> M-x geiser-connect-local.
>>
>> It works for me, but I’m not too familiar with elisp, so proper review
>> is in order. :-)
>
> After a very quick look, they look good to me, except for a little
> detail. Here:
>
> [...]
>
>> diff --git a/elisp/geiser-repl.el b/elisp/geiser-repl.el
>> index 995bb3b..316e6ea 100644
>> --- a/elisp/geiser-repl.el
>> +++ b/elisp/geiser-repl.el
>> @@ -290,7 +290,7 @@ module command as a string")
>> (marker-position (cdr comint-last-prompt)))
>> ((and (boundp 'comint-last-prompt-overlay)
>> comint-last-prompt-overlay)
>> (overlay-end comint-last-prompt-overlay))
>> - (t (save-excursion (geiser-repl--bol) (point)))))
>> + (t (save-excursion (end-of-line) (point)))))
>
> Why did you need to modify this bit? Is it related to unix-domain
> socket support too?
(Note that it’s in a separate patch.) I hit that line while hacking,
and it seemed obviously wrong. WDYT?
Thanks,
Ludo’.