Re: [Gnash-dev] [PATCH] Expand grayscale JPEG data to RGB

[Rob Savoye]

Bastiaan Jacques wrote:

> Well, that takes care of the "what", but not the "why". If I had to guess, 
> I'd 
> say that our image rendering engine wasn't designed for grayscale image data. 
> If that were the case, I'd prefer to fix the engine rather than the 
> conversion this patch adds.

  I agree with you 100%. This patch fixes this case, so I checked it in.
But it doesn't do anything for the larger problem of supporting
grayscale. I've never been a flash developer, so I have no idea if the
usage of grayscale in Flash movies is common, or rare.

  I would totally prefer to fix the engine, but I think that's a bigger
project. Whenever that happens, we can remove this simple patch. If
grayscale is a rarely used thing, I'm not sure if "doing this the right
way" is worth the effort unless it turns out to be a trivial extension.
I'd gladly except a patch that does this correctly though. :-)

        - rob -