[Gnash-dev] Re: [COMMITTED] inclusion of ffmpeg patch into Gnash 0.8.2 ?

[Hong Yu]

Thank you very much for all your support of FFmpeg option! We have been
much encouraged by your warm discussions. And from your suggestions, we
have had thoughts of how to further improve and debug FFmpeg media
handling for Gnash0.8.2.

Our modifications have excluded libmedia/sdl from compilation. In addition,
we don't need libmad as we are using mp3 decoder in ffmpeg.

Without previous experience of Gnash, our modifications are mainly to
recover the FFmpeg media handling code, with reference to Gnash0.8.1. It
will take us some time to remove most #ifdef in common classes for media
handling, and we will need to discuss with the current developer(s)
working on Gstreamer part. In the coming days, we will submit small bug-fix
patches step by step against release_0_8_2_rc1.

Using NetConnection to do network downloading for FFmpeg option is
Gnash0.8.1's way, we merely recovered it for Gnash0.8.2.

We are not very clear on the role of video_stream_def class, and added
#ifdef for FFmpeg compatibility. We may be able to remove #ifdef, but
that requires further discussion with gst developer.

Next thing for us is to check the documentation of aux_streamer in
libmedia/sound_handler, and research how to remove #ifdef of
aux_streamer in libmedia/sound_handler.

Best regards,

Hong Yu



strk wrote:
> On Fri, Feb 22, 2008 at 01:27:00PM +0100, strk wrote:
>   
> > On Fri, Feb 22, 2008 at 07:15:16PM +0800, Hong Yu wrote:
> >     
> > > Hello all!  We wonder if anyone has shown interest in our ffmpeg related 
> > > Gnash-cvs modifications and been trying tests with YouTube, etc.  Or any 
> > > additional suggestions? 
> > >       
> > We're all very interested in them, but it seems we didn't find the time
> > to give you feedback on it, being in the hard process of closing up the
> > release.
> >
> > I could look at it now, but is probably too late for 0.8.2 anyway.
> >
> > Consider joining #gnash on irc.freenode.net for a face-to-face 
> > discussion.
> >     
>
> After some discussion on the channel, and some testing I made with
> both gst and ffmpeg using your patch, we decided to commit it.
> So it is in the 0.8.2 branch now. 
> Thanks a lot.
>
> Next thing to look at (in head) would be proper abstractions to
> reduce (ideally drop) ifdefs around and duplication of common code.
>
> In particular, I belive using NetConnection for handlign the actual
> data download is the way to go (gstreamer uses its own modules for
> that).
>
> For the aux_streamer I still don't know as the whole sound_handler
> class is not properly documented as of yet - see top comments in
> libmedia/sound_handler.h, the \page section must be written
> completely. Documenting works would be appreciated.
>
> --strk;
>
>