Re: [Gnash-dev] Re: Nellymoser audio segfaults (bug #24355])

[Benjamin Wolsey]

> If the code doesn't do what the documentation says is a bug.
> Particularly important when code is virtual, and documentation
> is in base class.
> 
> Looks like this discussion should have been triggered *before* :)
> 

Yes, would have been better ... :)

> > And it has the advantage of allowing a single debugging
> > message telling you exactly what failed and where, instead of several
> > that don't tell you very much.
> 
> This is an interesting point. I'm new to exceptions, dunno how appropriate
> it'd be to use them as a logging mechanism.

It's the fact that it returns the error to the point that triggered it
that I like, which as a side effect is good for logging.

> What I've learnt as a use for them was "exceptional behaviour".
> How exceptional is for a media handler to NOT support a specific codec ?

I'd see it as a caller expecting to receive a decoder for data
(AudioInfo or SoundInfo) that it passes to MediaHandler. If it can't get
an object back because the data it passes is invalid, it's exceptional.

bwy

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil