Re: [Gnash-dev] Re: Nellymoser audio segfaults (bug #24355])

[Benjamin Wolsey]

> Please use only libmedia/MediaHandler.h as a document to read while
> we discuss this.
> I appreciate we're finally discussing the new design as that's important
> to avoid to many rewrites.
> 
> For example, there's no SoundInfo passed to MediaHandler (by design).
> 
Right, was confusing it with AudioDecoder, which takes both to setup().

> That said, yes: I'm fine with it returning an exception if it can't
> fullfill the request, with the request being: get me a decoder for
> this [audio/video].
> 
> Now. If we go that way we must:
> 
> 1) Update MediaHandler.h documentation
> 2) Update all users of it

There are only two users that would need updating: NetStream and
soundhandler (in both ffmpeg and gst forms).

> 3) Update all implementations

My patch already does this for everything but gst and mad. 

bwy

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil