[Gnash-dev] A few more build problem patches

[John Gilmore]

I found a workaround to my earlier problem; the patch:

=== modified file 'libmedia/gst/MediaParserGst.cpp'
--- libmedia/gst/MediaParserGst.cpp     2008-12-04 11:49:41 +0000
+++ libmedia/gst/MediaParserGst.cpp     2009-02-12 10:24:58 +0000
@@ -201,7 +201,8 @@
     if (!GST_FLOW_IS_SUCCESS (rv)) {
         log_error(_("MediaParserGst failed to push more data into the demuxer! 
"
                     "Seeking back."));
-        _stream->seek(_stream->tell()-ret);
+        std::streamoff crap = ret;     // C++ is badly broken
+        _stream->seek(_stream->tell() - crap);
         return false;
     }
     
Now the compile is failing in the kde support because the
step and jump methods were removed.  I diked them out in both 
kde.cpp and in klash3.moc (kdesup.h), with this set of changes:

=== modified file 'gui/kdesup.h'
--- gui/kdesup.h        2008-03-29 10:13:54 +0000
+++ gui/kdesup.h        2009-02-12 11:53:14 +0000
@@ -74,10 +74,6 @@
     void menuitem_play_callback();
     void menuitem_pause_callback();
     void menuitem_stop_callback();
-    void menuitem_step_forward_callback();
-    void menuitem_step_backward_callback();
-    void menuitem_jump_forward_callback();
-    void menuitem_jump_backward_callback();
 private:
     QPopupMenu    _qmenu;
     KdeGui*       _godfather;

=== modified file 'gui/kde.cpp'
--- gui/kde.cpp 2008-11-14 22:39:17 +0000
+++ gui/kde.cpp 2009-02-12 11:46:37 +0000
@@ -379,6 +379,7 @@
     _godfather->stop();
 }
 
+#if 0  /* These were apparently removed?? */
 /// \brief step forward 1 frame
 void
 qwidget::menuitem_step_forward_callback()
@@ -410,6 +411,7 @@
 //    GNASH_REPORT_FUNCTION;
     _godfather->menu_jump_backward();
 }
+#endif /* 0 */
 
 //
 // Event handlers


The KDE GUI doesn't appear to include the new media-saving preferences
(nor indeed any other preference-setting capability), but I didn't try
to fix that, never having programmed a KDE GUI before.

In the Ming tests I got 101 unexpected failures (I have the Ubuntu
ming, not the "very latest unpackaged" ming).  Those are appended below.
There are also huge numbers of errors (and "make check" actually halts
with an exit code) in astests-*-Runner, many XPASSes as well as FAILs.
I presume these are well known.

I also fixed a syntax error in testsuite/actionscript.all/XML.as:

=== modified file 'testsuite/actionscript.all/XML.as'
--- testsuite/actionscript.all/XML.as   2009-01-10 00:09:49 +0000
+++ testsuite/actionscript.all/XML.as   2009-02-12 12:09:34 +0000
@@ -309,8 +309,8 @@
        check_equals(this.childNodes[0], this.lastChild);
 
        check(this.childNodes.hasOwnProperty('length'));
-       check(this.childNodes[0] === this.firstChild);
-       check(this.childNodes[0] === this.lastChild);
+       check(this.childNodes[0] == this.firstChild);
+       check(this.childNodes[0] == this.lastChild);
 
        // childNodes is a read-only property !
        this.childNodes = 5;

Also, Instance.as is using some kind of new ming feature (asm) that
is apparently not in my version; the makefile should know to skip it.
I just kludged around that, not making a real fix.

With these changes, it builds and installs (but doesn't make it all the
way through "make check") on a recent x86 Ubuntu Hardy.  I can run it,
but Firefox 3.0.5 never finds the plugin.  (It found the 0.8.4 plugin,
which I removed with "apt-get remove mozilla-plugin-gnash", but it
doesn't find the one I installed in my home dir with "make install-plugin".)

Somehow I knew that just compiling and installing this was going to take
a whole day...

        John

make[3]: Entering directory `/home/gnu/src/gnash-bzr2/testsuite/misc-ming.all'
Making a new site.exp file...
WARNING: No tool specified
Test Run By gnu on Thu Feb 12 04:06:05 2009
Native configuration is i686-pc-linux-gnu

                ===  tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for 
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
WARNING: Couldn't find tool config file for unix, using default.
Running ./../simple.exp ...
FAIL: LoadVarsTestRunner: gprocessor returned an error while playing 
'LoadVarsTest.swf'
FAIL: DefineTextTest-Runner: expected: 288.05 obtained: 557.4 
[DefineTextTest.c:119] 
FAIL: DefineEditTextTest-Runner: expected: 'input' obtained: dynamic 
[DefineEditTextTest.c:217] 
FAIL: place_object_test2runner: expected: 3 obtained: 0 
[place_object_test2.c:114] 
FAIL: goto_frame_testrunner: expected: '/mc1' obtained:  
[goto_frame_test.c:152] 
FAIL: goto_frame_testrunner: expected: '/mc2' obtained:  
[goto_frame_test.c:153] 
FAIL: goto_frame_testrunner: expected: -16485 obtained:  
[goto_frame_test.c:179] 
FAIL: goto_frame_testrunner: expected: 'mc1' obtained:  [goto_frame_test.c:180] 
FAIL: goto_frame_testrunner: expected: -16485 obtained:  
[goto_frame_test.c:181] 
FAIL: goto_frame_testrunner: expected: 'mc2' obtained:  [goto_frame_test.c:182] 
FAIL: action_execution_order_extend_testrunner: expected: 'mc_red onLoad 
called' obtained:  [action_execution_order_extend_test.c:169] 
FAIL: action_execution_order_extend_testrunner: expected: 'mc_red onClipLoad 
called' obtained:  [action_execution_order_extend_test.c:170] 
FAIL: eventSoundTest1-Runner died prematurely (SIGABRT)
FAIL: action_execution_order_test1runner: expected: 'movieclip' obtained:  
[action_execution_order_test1.c:113] 
FAIL: action_execution_order_test1runner: expected: 'movieclip' obtained:  
[action_execution_order_test1.c:116] 
FAIL: action_execution_order_test1runner: expected: 'movieclip' obtained:  
[action_execution_order_test1.c:119] 
FAIL: action_execution_order_test1runner: expected: 'movieclip' obtained:  
[action_execution_order_test1.c:122] 
FAIL: action_execution_order_test1runner: expected: 1 obtained:  
[action_execution_order_test1.c:125] 
FAIL: action_execution_order_test1runner: expected: 1 obtained:  
[action_execution_order_test1.c:126] 
FAIL: action_execution_order_test3runner: expected: 
'as_in_DoAction1+as_in_DoAction2+onLoadRed1+onLoadRed2+as_in_DoAction3+onUnloadRed1+onUnloadRed2+'
 obtained: as_in_DoAction1+as_in_DoAction2+as_in_DoAction3+ 
[action_execution_order_test3.c:105] 
FAIL: action_execution_order_test4runner: expected: '01+02+03+' obtained:  
[action_execution_order_test4.c:226] 
FAIL: action_execution_order_test4runner: expected: 
'1+2+3+4+5+6+7+8+9+10+11+12+13+14+15+' obtained: 2+4+6+8+10+12+ 
[action_execution_order_test4.c:227] 
FAIL: action_execution_order_test5runner: expected: 
'1+2+3+4+5+6+7+8+9+10+11+12+13+14+15+' obtained:  
[action_execution_order_test5.c:253] 
FAIL: action_execution_order_test11runner: expected: '0+1+2+3+4+5+' obtained: 
0+ [action_execution_order_test11.c:235] 
FAIL: action_execution_order_test11runner: expected: 
'0+2+1+3+2+1+4+3+2+1+5+4+3+2+1+' obtained: 0+ 
[action_execution_order_test11.c:236] 
FAIL: action_execution_order_test11runner: expected: '0+1+2+3+4+5+' obtained: 
0+ [action_execution_order_test11.c:237] 
FAIL: action_execution_order_test11runner: expected: 
'0+1+2+3+4+5+6+3+8+4+10+6+3+4+14+15+25+10+26+6+27+3+28+4+29+20+21+22+23+24+' 
obtained: 0+25+26+27+28+29+ [action_execution_order_test11.c:239] 
FAIL: reverse_execute_PlaceObject2_test2runner: expected: 'onLoad+onLoad+' 
obtained:  [reverse_execute_PlaceObject2_test2.c:107] 
FAIL: reverse_execute_PlaceObject2_test2runner: expected: 'onUnload+onUnload+' 
obtained:  [reverse_execute_PlaceObject2_test2.c:108] 
FAIL: displaylist_depths_testrunner: expected: 7 obtained: 6 
[displaylist_depths_test.c:233] 
FAIL: displaylist_depths_testrunner: expected: 7 obtained: 6 
[displaylist_depths_test.c:277] 
FAIL: displaylist_depths_test2runner: expected: 2 , obtained: undefined
FAIL: displaylist_depths_test3runner: expected: 2 , obtained: undefined
FAIL: displaylist_depths_test4runner: expected: 1 , obtained: undefined
FAIL: displaylist_depths_test5runner: expected: 1 , obtained: undefined
FAIL: displaylist_depths_test9runner: expected: 2 obtained:  
[displaylist_depths_test9.c:154] 
FAIL: displaylist_depths_test9runner: expected: 3 obtained:  
[displaylist_depths_test9.c:159] 
FAIL: displaylist_depths_test10runner: expected: 1 , obtained: 
FAIL: displaylist_depths_test11runner: expected: 2 , obtained: 
FAIL: frame_label_testrunner: expected: 'mc11_frame4' obtained: 0 
[frame_label_test.c:151] 
FAIL: frame_label_testrunner: expected: 'mc11_frame5' obtained: 0 
[frame_label_test.c:152] 
FAIL: path_format_testrunner: expected: 'mc11_frame6' obtained: 0 
[path_format_test.c:284] 
FAIL: path_format_testrunner: expected: 'mc1_frame4' obtained: 0 
[path_format_test.c:285] 
FAIL: path_format_testrunner: expected: 'mc1_frame5' obtained: 0 
[path_format_test.c:286] 
FAIL: path_format_testrunner: expected: 'mc1_frame6' obtained: 0 
[path_format_test.c:287] 
FAIL: callFunction_testrunner: expected: 1 obtained: 0 
[callFunction_test.c:149] 
FAIL: callFunction_testrunner: expected: 1 obtained: 0 
[callFunction_test.c:153] 
FAIL: callFunction_testrunner: expected: 1 obtained: 0 
[callFunction_test.c:154] 
FAIL: duplicate_movie_clip_testrunner: expected: 2 obtained: 0 
[duplicate_movie_clip_test.c:112] 
FAIL: duplicate_movie_clip_testrunner: expected: 2 obtained: 0 
[duplicate_movie_clip_test.c:113] 
FAIL: duplicate_movie_clip_testrunner: expected: 2 obtained: 0 
[duplicate_movie_clip_test.c:121] 
FAIL: duplicate_movie_clip_testrunner: expected: 3 obtained: 0 
[duplicate_movie_clip_test.c:122] 
FAIL: duplicate_movie_clip_testrunner: expected: 2 obtained: 0 
[duplicate_movie_clip_test.c:123] 
FAIL: event_handler_scope_testrunner: expected: 1 obtained:  
[event_handler_scope_test.c:84] 
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 7) 
[key_event_testrunner.cpp:101]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 9) 
[key_event_testrunner.cpp:112]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 10) 
[key_event_testrunner.cpp:115]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 11) 
[key_event_testrunner.cpp:120]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 10) 
[key_event_testrunner.cpp:127]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 11) 
[key_event_testrunner.cpp:131]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 12) 
[key_event_testrunner.cpp:137]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 13) 
[key_event_testrunner.cpp:142]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 14) 
[key_event_testrunner.cpp:151]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 15) 
[key_event_testrunner.cpp:158]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 19) 
[key_event_testrunner.cpp:165]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 20) 
[key_event_testrunner.cpp:171]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 21) 
[key_event_testrunner.cpp:176]
FAIL: key_event_testrunner: root->get_current_frame() == '8' (expected: 22) 
[key_event_testrunner.cpp:184]
FAIL: NetStream-SquareTestRunner: expected: 'undefined' obtained: number 
[NetStream-SquareTest.c:261] 
FAIL: NetStream-SquareTestRunner: expected: 'undefined' obtained: number 
[NetStream-SquareTest.c:262] 
FAIL: NetStream-SquareTestRunner: expected: 'undefined' obtained: number 
[NetStream-SquareTest.c:265] 
FAIL: NetStream-SquareTestRunner: expected: 'undefined' obtained: number 
[NetStream-SquareTest.c:266] 
FAIL: NetStream-SquareTestRunner: expected: 100 obtained: 50 
[NetStream-SquareTest.c:269] 
FAIL: NetStream-SquareTestRunner: expected: 100 obtained: 50 
[NetStream-SquareTest.c:270] 
FAIL: NetStream-SquareTestRunner: expected: 0 obtained: undefined 
[NetStream-SquareTest.c:312] 
FAIL: NetStream-SquareTestRunner: expected: 0 obtained: undefined 
[NetStream-SquareTest.c:313] 
FAIL: NetStream-SquareTestRunner: expected: 0 obtained: undefined 
[NetStream-SquareTest.c:320] 
FAIL: NetStream-SquareTestRunner: expected: 0 obtained: undefined 
[NetStream-SquareTest.c:321] 
FAIL: NetStream-SquareTestRunner: expected: 0 obtained: undefined 
[NetStream-SquareTest.c:404] 
FAIL: NetStream-SquareTestRunner: expected: 0 obtained: undefined 
[NetStream-SquareTest.c:405] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:209] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:210] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:211] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:212] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:213] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:215] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:216] 
FAIL: loop_test8runner: expected: 'movieclip' obtained: undefined 
[loop_test8.c:224] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:225] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:226] 
FAIL: loop_test8runner: expected: 2 obtained: 0 [loop_test8.c:227] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:228] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:229] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:231] 
FAIL: loop_test8runner: expected: 1 obtained: 0 [loop_test8.c:232] 
FAIL: runtime_vm_stack_testrunner: expected: 1 obtained: 0 
[runtime_vm_stack_test.c:103] 
FAIL: runtime_vm_stack_testrunner: expected: 2 obtained: 0 
[runtime_vm_stack_test.c:104] 
FAIL: runtime_vm_stack_testrunner: expected: 3 obtained: 0 
[runtime_vm_stack_test.c:105] 
FAIL: runtime_vm_stack_testrunner: expected: 1 obtained: 0 
[runtime_vm_stack_test.c:123] 
FAIL: runtime_vm_stack_testrunner: expected: 2 obtained: 0 
[runtime_vm_stack_test.c:124] 
FAIL: runtime_vm_stack_testrunner: expected: 3 obtained: 0 
[runtime_vm_stack_test.c:125] 

                ===  Summary ===

# of expected passes            3673
# of unexpected failures        101
# of expected failures          28
# of untested testcases         168
make[3]: Leaving directory `/home/gnu/src/gnash-bzr2/testsuite/misc-ming.all'

Also, these other tests failed (boy, it sure is hard to tell whether
the tests are succeeding or failing, among all the output):