gnash-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Re: Burning 100% CPU time: MediaParser/FLVParser never p


From: John Gilmore
Subject: Re: [Gnash-dev] Re: Burning 100% CPU time: MediaParser/FLVParser never pauses
Date: Sun, 08 Aug 2010 14:30:44 -0700

> Your patch seems fine, and could eventually also make the call
> to waitIfNeeded deep in pushAVFrame needless.
> 
> Watch out for deadlocks, if you don't get any go ahead and commit
> it for broader testing.

Since I only check code into gnash every three or four years, it takes
me hours to figure out how to do it.  It's an incredible jumble of ssh
keys in a format I never otherwise use, and savannah, and bzr, and
NFS, and stuff like that.  (And now it looks like there's a git repo
too!)  Could somebody check in this four-line change for me?

> > > === modified file 'libmedia/MediaParser.cpp'
> > > --- libmedia/MediaParser.cpp      2010-01-01 17:48:26 +0000
> > > +++ libmedia/MediaParser.cpp      2010-08-06 02:34:19 +0000
> > > @@ -411,7 +411,10 @@
> > >   while (!parserThreadKillRequested())
> > >   {
> > >           parseNextChunk();
> > > -         gnashSleep(100); // no rush....
> > > +         {
> > > +                 boost::mutex::scoped_lock lock(_qMutex);
> > > +                 waitIfNeeded(lock);
> > > +         }
> > >   }
> > >  }

        John



reply via email to

[Prev in Thread] Current Thread [Next in Thread]