gnash-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Re: 0002-Translate-plugin.cpp-text-added.patch


From: Maximi89
Subject: Re: [Gnash-dev] Re: 0002-Translate-plugin.cpp-text-added.patch
Date: Thu, 14 Oct 2010 15:33:12 -0300



2010/10/14 Petter Reinholdtsen <address@hidden>

[Maximi89]
> From 631a7f66e855186e6b331c8a3afd806b5a93cf7a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Maximiliano=20Casta=C3=B1=C3=B3n=20Araneda?= <
> address@hidden>
> Date: Wed, 13 Oct 2010 00:44:11 -0300
> Subject: [PATCH 2/2] Translate plugin.cpp text added

I believe it is a mistake to translate this description.  It is used
by several web sites to decide which content they should serve to the
browser, and adding translated versions are going to cause gnash to
fail on sites that look for specific strings.
Actually, the sites try to retrieve the PLUGIN_DESCRIPTION, and PLUGIN_DESCRIPTION are:

#define PLUGIN_DESCRIPTION \
  "Shockwave Flash "FLASH_VERSION".<br>Gnash "VERSION", the GNU SWF Player. \
  Copyright (C) 2006, 2007, 2008, 2009, 2010 \
  <a href="" href="http://www.fsf.org">http://www.fsf.org\">Free \
  Software Foundation</a>, Inc. <br> \
  Gnash comes with NO WARRANTY, to the extent permitted by law. \
  You may redistribute copies of Gnash under the terms of the \
  <a href="" href="http://www.gnu.org/licenses/gpl.html\">http://www.gnu.org/licenses/gpl.html\">GNU General Public \
  License</a>. For more information about Gnash, see <a \
  href="" href="http://www.gnu.org/software/gnash/\">http://www.gnu.org/software/gnash/\"> \
  http://www.gnu.org/software/gnash</a>. \
  <br>\
  Compatible Shockwave Flash "FLASH_VERSION

PLUGIN_DESCRIPTION should be

#define PLUGIN_DESCRIPTION \
  "Shockwave Flash "FLASH_VERSION

Actually, bbc site and youtube retrieve this PLUGIN_DESCRIPTION, like both can't retrieve the version, youtube try with AVM1 support, and BBC, show a message telling us about "download the correct version of Adobe Flash Player", if we change the PLUGIN_DESCRIPTION to

#define PLUGIN_DESCRIPTION \
  "Shockwave Flash "FLASH_VERSION

both sites try AVM2, and BBC doesn't show any message...

for now fix this going to be impossible due to AVM2 are unsupported...

Greetings Petter!

Happy hacking,
--
Petter Reinholdtsen


_______________________________________________
Gnash-dev mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/gnash-dev



--
Maximiliano Augusto Castañón Araneda
Santiago, Chile
Linux user # 394821

Skype: maximi89
MSN: address@hidden
XMPP/Jabber: address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]