gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

stupid bug in xgnokii phonebook editor


From: chr []
Subject: stupid bug in xgnokii phonebook editor
Date: Sun, 26 Feb 2012 16:55:54 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Hi!

I've got a Nokia C1 phone, which does support multiple phone numbers per name
entry, that is the PM_EXTPBK flag, isn't it? xgnokii phone book editor shows up
correct but editing truncates the list.

Steps to reproduce: launch xgnokii, read phone book. Now create a new phone
book entry and add >1 numbers to it. Click ok, close the two dialogs. Reopen
the entry from the list, open the numbers list: it's truncated to one entry:

xgnokii/xgnokii_contacts.c line 395 in EditPhonebookEntry()

if (phoneMonitor.supported & PM_EXTPBK) {
    number = g_malloc(sizeof(char) * max_number_length);
    gtk_label_get(GTK_LABEL(data->number), number);
    snprintf(current_entry->entry.number, max_number_length, "%s", number[0]);
    snprintf(current_entry->entry.subentries[0].data.number, max_number_length,
"%s", number[0]);
    current_entry->entry.subentries[0].entry_type = GN_PHONEBOOK_ENTRY_Number;
    current_entry->entry.subentries[0].number_type =
GN_PHONEBOOK_NUMBER_General;
    // ??WTF::
    current_entry->entry.subentries_count = 1;
    g_free(number);
} else {
    snprintf(current_entry->entry.number, max_number_length, "%s",
         gtk_entry_get_text(GTK_ENTRY(data->number)));
}

This block doesn't make sense. Delete this block and the phone book works.
current_entry->entry.number is already set.

This is gnokii 0.6.32 from git/master @
4706c656ec05af5b44dbe98c075616817566329c



greets,

chr[]






reply via email to

[Prev in Thread] Current Thread [Next in Thread]