[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Sanitize dll exports
From: |
Ladislav Michl |
Subject: |
Re: Sanitize dll exports |
Date: |
Sun, 09 Jan 2022 21:56:59 +0100 |
User-agent: |
Evolution 3.38.3-1 |
Hi Pawel,
GNOKII_API is used also in smsd/db.h, etc. It should not be there, so I
put notce to commit message.
-DLOCALEDIR and DEFS was not passed to inner Makefiles CPP flags.
ladis
-----Original Message-----
From: Pawel Kot <gnokii@gmail.com>
To: Ladislav Michl <ladis@linux-mips.org>, Discussion forum for gnokii
users. <gnokii-users@nongnu.org>
Subject: Sanitize dll exports
Date: Sun, 9 Jan 2022 20:09:50 +0100
Hi Ladis,
I can see three sets of changes in this commit:
1. Removal of GNOKIIDLL_EXPORTS and GNOKIIDLL_IMPORTS replacing with
COMPILING_LIBGNOKII. This part is clear. However, can you elaborate on
how "GNOKII_API is (mis)used by smsd plugins"?
2. automake related change between AC_LIBTOOL_WIN32_DLL and
LT_INIT([win32-dll]) - I've seen this done also by autoupdate, so no
questions here
3. Juggling with -DLOCALEDIR and DEFS in Makefile. Can you explain what
is going on here?
Cheers,