Re: [PATCH] ressources/coreboot/fam15h*: fix building crossgcc 8.3.0 (fixes #64870)

[Denis 'GNUtoo' Carikli]

On Sun,  8 Sep 2024 21:40:13 +0200
Adrien Bourmault <neox@gnu.org> wrote:

> This commit fixes an error encountered on Trisquel 11 while trying to
> build the fam15h coreboot crossgcc 8.3.0:
Thanks a lot for working on that. It's an "order of magnitude" better
approach than my workaround that added a settings to enable users to
disable the build for these computers.

> This error has been corrected on upstream GCC by Eric Botcazou
> <ebotcazou@adacore.com> but this was not applied on upstream coreboot
> (even 4.11 branch)
[...]
> +Date: Fri, 5 Mar 2021 12:45:41 +0100
> +Subject: [PATCH] Fix build breakage with latest glibc release
> +To: gcc-patches@gcc.gnu.org
> +
> ++From a5a7cdcaa0c29ee547c41d24f495e9694a6fe7f1 Mon Sep 17 00:00:00
> 2001 ++From: Eric Botcazou <ebotcazou@adacore.com>
> ++Date: Fri, 5 Mar 2021 12:45:41 +0100
> ++Subject: [PATCH] Fix build breakage with latest glibc release
[...]
> @@ -0,0 +1,70 @@ +From 3a1ff2c972975b16812a96b800d34073edf9302d Mon
> Sep 17 00:00:00 2001 +From: Eric Botcazou <ebotcazou@adacore.com>
> +Date: Fri, 5 Mar 2021 12:45:41 +0100
> +Subject: [PATCH] Fix build breakage with latest glibc release

The problem I have here is that I'm not familiar enough with GCC
development and me or future GNU Boot maintainers or contributors are
not supposed to be.

So more background information with a focus on maintenance would help.
More precisely:

- Where does the patch comes from exactly? Can we have a link to it? I
  guess that given that there is a To: they probably comes from the GCC
  mailing list, but I also found it in GCC's git repository (commit
  331763de7d4850702a0f67298f36017c73cdb103 ("Fix build breakage with
  latest glibc release")). Also something is strange with that commit:
  $ git describe 331763de7d4850702a0f67298f36017c73cdb103
  misc/first-auto-changelog-6901-g331763de7d4

- What's the status of upstreaming this patch? If I've a given GCC
  version, can I know if it needs this patch? Or where to check for the
  patch status if possible?

The information I'm looking for are typically found in things like the
standard patch header from Debian[1], an example can be found in one of
the GNU Boot patches[2] where the context wasn't enough to have all the
information needed on the patch. 

This standard header was also reused by another project
(Yocto/Openembedded) so it's broader than just Debian, but I'm unsure
how many non-debian distros uses it. 

So we could also consider requiring this header (in certain conditions
or all the time) for new patches that we bring in GNU Boot later on.

Obviously we'd need to modify the documentation/website to make it
official if we choose to go this way.

References:
-----------
[1]https://dep-team.pages.debian.net/deps/dep3/
[2]resources/guix/gnuboot/patches/flashrom-1.2.patch

Denis.

pgpvLlhf7P1SC.pgp
Description: OpenPGP digital signature