gnuboot-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v1 1/3] coreboot: blobs.list: arm-trusted-firmware: Remove RK3399


From: Denis 'GNUtoo' Carikli
Subject: [PATCH v1 1/3] coreboot: blobs.list: arm-trusted-firmware: Remove RK3399 hdcp.bin firmware.
Date: Sun, 3 Nov 2024 23:43:14 +0100

This was introduced in ARM trusted firmware in the commit
c76631c52b0b1550ff182c177555485700274314 ("rockchip: include hdcp.bin
and declare hdcp key decryption handler").

The hdcp.bin file contains code as it is included inside one of the
arm-trusted-firmware drivers with the following code:
    __asm__(
           ".pushsection .text.hdcp_handler, \"ax\", %progbits\n"
           ".global hdcp_handler\n"
           ".balign 4\n"
           "hdcp_handler:\n"
           ".incbin \"" __XSTRING(HDCPFW) "\"\n"
           ".type hdcp_handler, %function\n"
           ".size hdcp_handler, .- hdcp_handler\n"
           ".popsection\n"
    );

The same file file that contains the above code has the following
copyright header:
    * Copyright (c) 2017-2018, ARM Limited and Contributors. All rights 
reserved.
    *
    * SPDX-License-Identifier: BSD-3-Clause

This conflicts with the message of the commit mentioned above:
    For some reason, HDCP key decrytion can't open source in ATF, so we
    build it as hdcp.bin. Besides declare the handler for decrypting.
and we also have missing corresponding source code.

Because of the lack of source code, and the fact that GNU Boot doesn't
support computers with RK3399 yet, it's easier to remove the hdcp.bin
firmware than to pursue other ways to fix the issue.

Reported-by: Leah Rowe <info@minifree.org>
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
 resources/coreboot/default/blobs.list      | 1 +
 resources/coreboot/fam15h_rdimm/blobs.list | 1 +
 resources/coreboot/fam15h_udimm/blobs.list | 1 +
 3 files changed, 3 insertions(+)

diff --git a/resources/coreboot/default/blobs.list 
b/resources/coreboot/default/blobs.list
index 7d8ff5a..b6fcb66 100644
--- a/resources/coreboot/default/blobs.list
+++ b/resources/coreboot/default/blobs.list
@@ -2,6 +2,7 @@
 3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/drivers/spm/spm_mcdi.c
 3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/drivers/spm/spm_suspend.c
 
3rdparty/arm-trusted-firmware/plat/rockchip/rk3368/drivers/ddr/rk3368_ddr_reg_resume_V1.05.bin
+3rdparty/arm-trusted-firmware/plat/rockchip/rk3399/drivers/dp/hdcp.bin
 3rdparty/chromeec/test/legacy_nvmem_dump.h
 3rdparty/chromeec/third_party/bmi260/accelgyro_bmi260_config_tbin.h
 3rdparty/vboot/tests/futility/data/*
diff --git a/resources/coreboot/fam15h_rdimm/blobs.list 
b/resources/coreboot/fam15h_rdimm/blobs.list
index 5752a17..f40c715 100644
--- a/resources/coreboot/fam15h_rdimm/blobs.list
+++ b/resources/coreboot/fam15h_rdimm/blobs.list
@@ -2,6 +2,7 @@
 3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/drivers/spm/spm_mcdi.c
 3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/drivers/spm/spm_suspend.c
 
3rdparty/arm-trusted-firmware/plat/rockchip/rk3368/drivers/ddr/rk3368_ddr_reg_resume_V1.05.bin
+3rdparty/arm-trusted-firmware/plat/rockchip/rk3399/drivers/dp/hdcp.bin
 3rdparty/chromeec/test/legacy_nvmem_dump.h
 3rdparty/vboot/tests/futility/data/*
 src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch03000002.c
diff --git a/resources/coreboot/fam15h_udimm/blobs.list 
b/resources/coreboot/fam15h_udimm/blobs.list
index 5752a17..f40c715 100644
--- a/resources/coreboot/fam15h_udimm/blobs.list
+++ b/resources/coreboot/fam15h_udimm/blobs.list
@@ -2,6 +2,7 @@
 3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/drivers/spm/spm_mcdi.c
 3rdparty/arm-trusted-firmware/plat/mediatek/mt8173/drivers/spm/spm_suspend.c
 
3rdparty/arm-trusted-firmware/plat/rockchip/rk3368/drivers/ddr/rk3368_ddr_reg_resume_V1.05.bin
+3rdparty/arm-trusted-firmware/plat/rockchip/rk3399/drivers/dp/hdcp.bin
 3rdparty/chromeec/test/legacy_nvmem_dump.h
 3rdparty/vboot/tests/futility/data/*
 src/vendorcode/amd/agesa/f12/Proc/CPU/Family/0x12/F12MicrocodePatch03000002.c
-- 
2.46.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]