Re: [PATCH 3/6] website: css/template: add the GNU Boot logo

[Denis 'GNUtoo' Carikli]

On Mon, 25 Nov 2024 17:44:00 +0100
Adrien 'neox' Bourmault <neox@gnu.org> wrote:

> This commit adds the GNU Boot logo on the website title zone.
> 
> Signed-off-by: Adrien 'neox' Bourmault <neox@gnu.org>
> ---
>  website/pages/favicon.png      | Bin 0 -> 13404 bytes
>  website/pages/global.css       |   2 +-
>  website/pages/template.include |   3 +++
>  3 files changed, 4 insertions(+), 1 deletion(-)
>  create mode 100644 website/pages/favicon.png
> diff --git a/website/pages/global.css b/website/pages/global.css
> index 0a348f9..225f47d 100644
> --- a/website/pages/global.css
> +++ b/website/pages/global.css
> @@ -55,7 +55,7 @@ img,video,iframe{max-width:100%}
>  }
>  html,ul,#TOC{padding:1em}
>  @media (min-width:60em) {
> -     .title-logo{display:none}
> +     .title-logo{display:float}
>       div.title {background-position:right}
>       h1.title {padding:0 4em}
>       #TOC{min-width:25%}
> diff --git a/website/pages/template.include
> b/website/pages/template.include index 9871df0..8c6e4de 100644
> --- a/website/pages/template.include
> +++ b/website/pages/template.include
> @@ -41,6 +41,9 @@ $endfor$
>  $if(title)$
>  <header>
>  <div class="title">
> +<p class="title-logo">
> +<img class="title-logo" alt="GNU Boot logo"
> src="/software/gnuboot/web/favicon.png" /> +</p>
>  <h1 class="title">$title$</h1>
>  </div>
>  $if(subtitle)$

I see several issues / possible improvements here:
- The file name is favicon and a favicon typically doesn't show up on
  the page itself. See https://en.wikipedia.org/wiki/Favicon in case
  where you don't already know that.

- The small logo shows up on the top of the page and it has no link
  inside it. In many websites like English Wikipedia, Guix, etc the
  logo has a link inside that points to the main page. In the case of
  GNU the logo is in the middle but then it's also separate from the
  rest, and here we end up having the title of the page on top of the
  bar, so it's probably not ideal to mix the logo with that. So I think
  it would be better to put the logo on the top-left and to add a link
  inside. Another option would be to fix these page titles but that's
  probably more work.

- The commit message lacks information on how this small file was
  produced. It was probably derived from the GNU Boot logo I guess,
  maybe this file: resources/grub/background/background1024x768.png ?
  How was it done? Like by hand by resizing the picture? By selecting
  the shoe and pasting it on a transparent background?

Denis.

pgp8zVGhNeeB5.pgp
Description: OpenPGP digital signature