[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: scope and CARD_LIST:_card_list
From: |
Felix Salfelder |
Subject: |
Re: scope and CARD_LIST:_card_list |
Date: |
Sat, 30 Jan 2021 10:15:12 +0100 |
On Fri, Jan 29, 2021 at 04:19:21PM -0500, al davis wrote:
> the s_* files. It needs to be extended to all. Use the Scope argument
> to do_it(), instead of direct access to CARD_LIST::card_list.
>
> To check that it really works, add check code:
>
> void XXXXXXXXXX::do_it(CS& Cmd, CARD_LIST* Scope)
> {
> assert(Scope);
> if (Scope == &CARD_LIST::card_list) {untested();
> }else{untested();
> }
>
> Then change all CARD_LIST::card_list to Scope->
Did that in scope-2 for the COMMANDs. Only the case Scope ==
&CARD_LIST::card_list is reached from the tests. Somewhat expectedly.
some issues:
- CARD_LIST::card_list is used in u_sim_data.cc, but SIM_DATA does not
have a scope (yet?)
- same with PROBELIST::add_*
- OPT is all static, but to some degree it holds circuit parameters.
cheers
felix