Re: [Gnumed-bugs] Bug (?) trying to sign multiple results?

[Karsten Hilbert]

On Fri, Sep 23, 2011 at 05:43:51PM -0700, Jim Busser wrote:

> In 0.9.9 ...
> 
> ... if I select a cell in which reside three (multiple)
> results, then even when I have selected all three, the
> middle one is unactioned (unsigned) despite that all had
> been selected before I reached, and checkboxed "sign"
> within, the subsequent signing dialog.

The "subsequent signing dialog" does not contain a
'checkbox "sign"' ?

Something similar to what you describe is this:

- select multiple results
        regardless whether in separate cells or within a single cell

- invoke "review and sign"

- DO NOT review
        by not selecting any of relevant/irrelevant
                AND
        not any of normal/out-of-range
                AND
        do NOT transfer responsibility to yourself
                AND
        do NOT add a comment

- hit [Apply]

In this case something maybe not quite expected but
certainly very logical happens: One is applying "doing
nothing" to the previously selected results.

The perceived strangeness results from the misunderstanding
that there exists a "sign" separate from "review".

*Howver* there existed one inconsistency:

- do the above except to one single unreviewed result

This would end in said result to appear properly reviewed.
The technical reason being that GNUmed allowed the comment
to be set but failed to properly consider an empty comment
field to mean "comment not set" for as-yet unreviewed
results (as opposed to previously reviewed results where it
can usefully mean "unset now").

In short, GNUmed now does not anymore try to second-guess
the intention of the reviewer when nothing has been done to
actually review except hitting [Apply] - which should
properly result in "nothing" being applied.

> Also, can the dialog that is evoked, when having to select
> from among a field with multiple results (screenshot) grow
> an All button which would select all results within the
> cell?

That is not currently possible with the code as-is.

> (If yes, but not immediately, should I add to
> wishlist)?

Yes.

Karsten
-- 
GPG key ID E4071346 @ gpg-keyserver.de
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346