[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Small patch for src/util/test_os_start_process.c
From: |
Christian Grothoff |
Subject: |
Re: Small patch for src/util/test_os_start_process.c |
Date: |
Wed, 6 Jan 2021 09:54:06 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
Hi Sebastian,
Yeah, makes sense to me (for busybox-systems). I've slightly extended
your patch to also remove the silly 'fn' construction of the test case.
Fixed in 438aca2f6..90499cabe
Happy hacking!
Christian
On 1/5/21 9:43 PM, Sebastian Javier Marchano wrote:
> Hello!
>
> I was playing around with gnunet and alpine and it seems that this
> test (os start process) breaks because alpine uses the same binary for
> some commands (/bin/busybox) and relies on the filename for the command
> name.
>
> Best regards
>
> diff --git a/src/util/test_os_start_process.c
> b/src/util/test_os_start_process.c
> index ff5021d03..7e5cde1a9 100644
> --- a/src/util/test_os_start_process.c
> +++ b/src/util/test_os_start_process.c
> @@ -138,7 +138,7 @@ run_task (void *cls)
> GNUNET_OS_start_process (GNUNET_OS_INHERIT_STD_ERR,
> hello_pipe_stdin, hello_pipe_stdout, NULL,
> fn,
> - "test_gnunet_echo_hello", "-", NULL);
> + "cat", "-", NULL);
> GNUNET_free (fn);
>
> /* Close the write end of the read pipe */
>
>
>
> --
> Sebastian
signature.asc
Description: OpenPGP digital signature