gnunet-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Request Review (testing/helper)


From: ch3
Subject: Request Review (testing/helper)
Date: Fri, 27 Sep 2024 14:34:58 +0200

Hello,

could someone please have a look at my last commit?
https://git.gnunet.org/gnunet.git/commit/?id=0a0f332664271ea4d53a0276638a407e92b01483

Besides general sanity checks, I specifically am curious about:

 1. Along the lines of the FIXME in helper.c: Is it intended behavior
    that a helper gets shut down if it has an exception handler, but if
    it doesn't it gets restarted?

 2. Testing keeps a list of helpers in ns->helpers[]. When one of the
    helpers' exception callbacks is called - would it be desirable to
    take it out of the array, or is it fine to just mark it as finished?

Thanks in advance,
ch3

Attachment: binlM_hvpCAj4.bin
Description: PGP Key 0x494E1084E37E08C8F539C0C1FA15A4D6BF109DF5.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]