[taler-exchange] branch master updated: improve logging

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 8e1ef6a5b improve logging
8e1ef6a5b is described below

commit 8e1ef6a5b1927f5438d05b7333a1e14eb04003ce
Author: Christian Grothoff <christian@grothoff.org>
AuthorDate: Fri Dec 13 13:09:25 2024 +0100

    improve logging
---
 contrib/gana                                   | 2 +-
 src/exchange/taler-exchange-httpd_common_kyc.c | 9 +++++++--
 src/exchangedb/pg_insert_kyc_measure_result.c  | 1 -
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/contrib/gana b/contrib/gana
index bc21a8e21..bc0a0add2 160000
--- a/contrib/gana
+++ b/contrib/gana
@@ -1 +1 @@
-Subproject commit bc21a8e216c96093744a819699d48de7fcaec5b3
+Subproject commit bc0a0add2f5019b720f245dbfc36951630388aa1
diff --git a/src/exchange/taler-exchange-httpd_common_kyc.c 
b/src/exchange/taler-exchange-httpd_common_kyc.c
index ab42ad01e..a88113a17 100644
--- a/src/exchange/taler-exchange-httpd_common_kyc.c
+++ b/src/exchange/taler-exchange-httpd_common_kyc.c
@@ -985,7 +985,10 @@ legi_fail (struct TEH_LegitimizationCheckHandle *lch,
            enum TALER_ErrorCode ec,
            const char *details)
 {
-  GNUNET_break (0);
+  GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+              "Legitimziation process failed: %s (%s)\n",
+              TALER_ErrorCode_get_hint (ec),
+              details);
   lch->lcr.http_status
     = TALER_ErrorCode_get_http_status (ec);
   lch->lcr.response
@@ -1046,7 +1049,9 @@ legi_check_aml_trigger_cb (
   if (lch->rerun > MAX_LEGI_LOOPS)
   {
     /* deep recursion not allowed, abort! */
-    GNUNET_break (0);
+    GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                "Deep recursion (> %u) detected in AML programs, aborting\n",
+                (unsigned int) MAX_LEGI_LOOPS);
     legi_fail (lch,
                TALER_EC_EXCHANGE_KYC_RECURSIVE_RULE_DETECTED,
                NULL);
diff --git a/src/exchangedb/pg_insert_kyc_measure_result.c 
b/src/exchangedb/pg_insert_kyc_measure_result.c
index 7ef671463..c8698c7b4 100644
--- a/src/exchangedb/pg_insert_kyc_measure_result.c
+++ b/src/exchangedb/pg_insert_kyc_measure_result.c
@@ -79,7 +79,6 @@ TEH_PG_insert_kyc_measure_result (
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Inserting KYC attributes, wake up on %s\n",
               kyc_completed_notify_s);
-  GNUNET_break (NULL != new_rules);
   GNUNET_break (NULL != h_payto);
   PREPARE (pg,
            "insert_kyc_measure_result",

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.