[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnushogi-devel] [Patch 0/1] Switch to getopt cmdline parsing
From: |
Chen Chen |
Subject: |
Re: [Gnushogi-devel] [Patch 0/1] Switch to getopt cmdline parsing |
Date: |
Thu, 8 Feb 2018 01:47:25 +0000 |
Hi Justin,
The patch seems quite good. The hand-written argument parsing is indeed
out-of-date.
And yes, the development of this repo has been stalled for years.
Regards,
Chen
On 2018/2/5 5:25, Justin Vreeland wrote:
> I started using gnushogi to play shogi and noticed some slight issues, but
> looking at the commit history doesn't seem to be activly developed. It only
> seemed polite to send a patch when inquiring about the development status so
> here's a first pass at switching to getopt for argument parsing found in
> the todo.
>
> The main difference I've noticed is that this patch produces and error & usage
> when '--' options are used where the current method seems to ignore invalid
> options and just produce the usage text.
>
> This hasn't been fully tested, just wanted to gauge the reaction before
> I spent time testing and cleaning it up.
>
> Justin Vreeland (1):
> Switch the argument parsing to getopt
>
> gnushogi/main.c | 130
> +++++++++++++++++++++-----------------------------------
> 1 file changed, 49 insertions(+), 81 deletions(-)
>