gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH 1/2] Moves Linux-only ppscheck program back to con


From: Fred Wright
Subject: Re: [gpsd-dev] [PATCH 1/2] Moves Linux-only ppscheck program back to contrib/.
Date: Wed, 10 Aug 2016 15:23:59 -0700 (PDT)

On Wed, 10 Aug 2016, Robert Norris wrote:

> AFAIK scons cleans/builds all the programs it knows about.
>
> However in the gpsd SConstruct there are code paths for 'cleaning' and
> 'building', so both paths must generate the same list of programs so
> they can be built or cleaned.

Generally speaking, yes, but the configure stuff is sufficiently slow and
verbose that it's mostly bypassed in the "cleaning or helping" cases.

> Thus I believe the pps (and so also the kpps) tests need to be before
> the "if cleaning or helping:" line 617, but after the variable config is
> made available.

It's much simpler to fix than that.  There's no problem *cleaning*
ppscheck on any platform.  Patch coming.

Fred Wright



reply via email to

[Prev in Thread] Current Thread [Next in Thread]