gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] Checking API versions


From: Michael J. Tubby B.Sc. MIET
Subject: Re: [gpsd-dev] Checking API versions
Date: Mon, 6 Nov 2017 09:20:47 +0000
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

Gary,

I think the issue is that we're trying to version control several things:

1. GPSD itself, e.g. 'release' 3.17 which has a major of '3' and a minor of '17'

2. GPSD's most recent version, e.g. major '3' and minor '12' since nothing external has changed between 3.12 and 3.17

3. The JSON protcol interface level - which may also be 3.12 (or something different)

4. the libgps API version, which appears to be 6.1

Perhaps version_t needs to be bumped from:

struct version_t {
    char release[64];                   /* external version */
    char rev[64];                       /* internal revision ID */
    int proto_major, proto_minor;       /* API major and minor versions */
    char remote[GPS_PATH_MAX];          /* could be from a remote device */
};

to:

struct version_t {
    char release[64];                   /* external version */
    char rev[64];                       /* internal revision ID */
    int release_major, release_minor,   /* release as two part integers */
    int proto_major, proto_minor;       /* JSON protocol major and minor versions */
    int api_major, api_minor;           /* API (libgps) major and minor versions */
    char remote[GPS_PATH_MAX];          /* could be from a remote device */
};

then we'd have everything and it could be testable programmatically.


Mike
On 11/6/2017 12:14 AM, Gary E. Miller wrote:
Yo Michael!

On Sun, 5 Nov 2017 19:11:02 +0000
"Michael J. Tubby B.Sc. MIET" <address@hidden> wrote:

The problem is that:

     proto_major != GPSD_API_MAJOR_VERSION

     proto_major = 3
     GPSD_API_MAJOR_VERSION = 6
Hmm, sorry, I spoke too soon.  After some looking, I see the issue is
sorta documents in gpsd_json.5, but could use a lot of work.

I opened a bug on it: https://savannah.nongnu.org/bugs/index.php?52347

Until it gets fixed you can try to parse the version stiring, or just
hardcode proto_major s/b 3.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
	address@hidden  Tel:+1 541 382 8588

	    Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

--

Michael J Tubby B.Sc MIET / Technical Director / +44 (0)7973 225144

Thorcom Systems Ltd
Office: +44 (0)1905 756 700 / Fax: +44 (0)1905 755 777
Unit 4, 96B Blackpole Trading Estate West, Worcester, WR3 8TJ Registered in England & Wales 2704696 / VAT number GB 487 9256 81
www.thorcom.co.uk


reply via email to

[Prev in Thread] Current Thread [Next in Thread]