gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] Fix SConstruct to work with Python 3


From: teyrana
Subject: Re: [gpsd-dev] [PATCH] Fix SConstruct to work with Python 3
Date: Tue, 13 Feb 2018 18:21:12 -0500

FYI, I tested Robert's patch and it doesn't quite run on Ubuntu 18.04.  Fortunately, it can be fixed with some minor tweaking:

Environment:
----
Reproduced with: 
Ubuntu 18.04 Bionic Beaver (development branch) (docker image)
Python @ 3.6.4
SCons @ v3.0.1.7


Error:
----
NameError: name 'reduce' is not defined:
  File "/root/gpsd/SConstruct", line 1485:
    generated_sources)
  File "/root/gpsd/SConstruct", line 1471:
    files = reduce(operator.add, map(glob.glob, patterns), [])


Fix:
----
This can be fixed by simply including the function:
-----
diff --git a/SConstruct b/SConstruct
index 17b47e21..d9d75653 100644
--- a/SConstruct
+++ b/SConstruct
@@ -85,6 +85,7 @@ import sys
 import time
 from distutils import sysconfig
 from distutils.util import get_platform
+from functools import reduce
 import SCons
 





Daniel Williams
address@hidden
858-220-8134 (Mobile)
339-368-6425 (Skype)
LinkedIn
GitHub

On Sun, Feb 11, 2018 at 4:28 PM, Gary E. Miller <address@hidden> wrote:
Yo teyrana!

On Sun, 11 Feb 2018 11:21:15 -0500
teyrana <address@hidden> wrote:

> Ooooh, nice!
>
> That will make it much easier to build what we need :)

If you can confirm it works for you I'll push it to git head.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin


reply via email to

[Prev in Thread] Current Thread [Next in Thread]