Re: [gpsd-dev] GPSD Compile warnings with GCC-8 on Devuan Beowulf

[Michael J. Tubby B.Sc. MIET]

Ok, but is that fix in the current head only?  I was compiling 3.18.1 from the release tarball.

Mike

On 12/04/2019 04:06, Sanjeev Gupta wrote:

Mike, this should have been fixed in:

commit 71bd775bb579b8aabccfb6cd36a17a8281070829
Author: Sanjeev Gupta <address@hidden>
Date:   Tue Jan 29 21:53:58 2019 +0800

    Fix a warning from gcc: vwprintw is deprecated

    The function vwprintw, declared in curses.h is called out by gcc
    because of its use of varargs.h .  The actaul implementation uses
    stdarg.h , however GCC does not know this.  Switch to the newer
    calling form to make gcc happy.

    gcc -o gpsmon.o -c -pthread -Wall -Wcast-align -Wextra -Wimplicit-fallthrough -Wmissing-declarations -Wmissing-prototypes -Wno-missing-field-initializers -Wno-uninitialized -Wpointer-arith -Wreturn-type -Wstrict-prototypes -Wvla -O2 -pthread -DHAVE_SYS_TIMEPPS_H=1 -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -I/usr/include/libusb-1.0 gpsmon.c
    gpsmon.c: In function 'monitor_vcomplain':
    gpsmon.c:392:5: warning: 'vwprintw' is deprecated [-Wdeprecated-declarations]
         (void)vwprintw(cmdwin, (char *)fmt, ap);
         ^
    In file included from gpsmon.h:11,
                     from gpsmon.c:31:
    /usr/include/curses.h:816:28: note: declared here
     extern NCURSES_EXPORT(int) vwprintw (WINDOW *, const char *,va_list) GCC_DEPRECATED(use vw_printw); /* implemented */
                                ^~~~~~~~
    gpsmon.c: In function 'monitor_log':
    gpsmon.c:419:2: warning: 'vwprintw' is deprecated [-Wdeprecated-declarations]
      (void)vwprintw(packetwin, (char *)fmt, ap);
      ^
    In file included from gpsmon.h:11,
                     from gpsmon.c:31:
    /usr/include/curses.h:816:28: note: declared here
     extern NCURSES_EXPORT(int) vwprintw (WINDOW *, const char *,va_list) GCC_DEPRECATED(use vw_printw); /* implemented */
                                ^~~~~~~~

--
Sanjeev Gupta
+65 98551208     http://www.linkedin.com/in/ghane

On Fri, Apr 12, 2019 at 4:28 AM Mike Tubby <address@hidden> wrote:

Gary, Eric

I got fed up with systemd entanglement on one of our
nameservers/timeservers today so flattened it and rebuilt it with Devuan
Beowulf (like Debian Buster but systemd free) - these OSes come with
GCC-8 which brings new compile warnings to an otherwise clean build:

gpsmon.c: In function 'monitor_vcomplain':
gpsmon.c:393:5: warning: 'vwprintw' is deprecated
[-Wdeprecated-declarations]
      (void)vwprintw(cmdwin, (char *)fmt, ap);
      ^
In file included from gpsmon.h:11,
                  from gpsmon.c:32:
/usr/include/curses.h:816:28: note: declared here
  extern NCURSES_EXPORT(int) vwprintw (WINDOW *, const char *,va_list)
GCC_DEPRECATED(use vw_printw); /* implemented */
                             ^~~~~~~~
gpsmon.c: In function 'monitor_log':
gpsmon.c:420:2: warning: 'vwprintw' is deprecated
[-Wdeprecated-declarations]
   (void)vwprintw(packetwin, (char *)fmt, ap);
   ^
In file included from gpsmon.h:11,
                  from gpsmon.c:32:
/usr/include/curses.h:816:28: note: declared here
  extern NCURSES_EXPORT(int) vwprintw (WINDOW *, const char *,va_list)
GCC_DEPRECATED(use vw_printw); /* implemented */
                             ^~~~~~~~

Mike

--

Michael J Tubby B.Sc. (Hons) MIET / Technical Director
Email: address@hidden
Direct: +44 (0)1905 752892
Mobile: +44 (0)7973 225144

Thorcom Systems Limited
Phone: +44 (0)1905 756 700
Address: Unit 4, 96B Blackpole Trading Estate West, Worcester, WR3 8TJ, England, UK
Company registered in England & Wales No. 02704696 / VAT Number GB487925681 / EORI GB487925681000

This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed.
Any views or opinions expressed are solely those of the author and do not necessarily represent those of Thorcom Systems Limited.
If you are not the intended recipient of this email, you must not take any action based upon its contents or disclose it to any third-party.
Please contact the sender if you believe you have received this email in error.