Re: [gpsd-dev] cfmakeraw part 2

[Gary E. Miller]

Yo Greg!

On Thu, 20 Jun 2019 11:27:56 -0400
Greg Troxel <address@hidden> wrote:

> "Gary E. Miller" <address@hidden> writes:
> 
> > Can you first see waht this says:
> >     fgrep -r cfmakeraw /usr/include
> >
> > Every other OS seems to have cfmakeraw() in there somewhere...  
> 
> Apparently not cygwin, and POSIX does not specify cfmakeraw.
> 
> These days, most of the Solaris codebase lives on (as Free Software)
> under the name Illumos.  A variant of that, SmartOS, is used by joyent
> in their cloud offering, and that uses pkgsrc as the standard
> packaging system.  So we have a lot of fixes found by building on
> Solaris, while which I'm sure include some Solaris bugs, seem to be
> mostly beyond-POSIX assumptions.

Yes, but can we test it?  Guessing at fixes is dangerous and wasteful.

Looking at the Illumos site I don't see how gpsd could ever run on that.

> Fix pushed; should not affect other than __sun, and be easier to
> extend if a third system without cfmakeraw appears.  (Really this
> should be in configure with HAVE_CFMAKERAW, but that seems like more
> work than the expected value of special casing.)

It is actually pretty easy, and preferable.  But without a test bed
we should avoid it all.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin

pgpygu3PaoYw6.pgp
Description: OpenPGP digital signature