Re: grep-3.8.11-908f on Solaris 11.4

[Jim Meyering]

On Mon, Jan 2, 2023 at 2:03 AM Bruno Haible <bruno@clisp.org> wrote:
>
> On Solaris 11.4, this grep snapshot fails to compile:
>
>   CC       libgreputils_a-localeinfo.o
> ../../lib/localeinfo.c:33:39: error: macro "static_assert" requires 2 
> arguments, but only 1 given
>  static_assert (MB_LEN_MAX <= SCHAR_MAX);
>                                        ^
> ../../lib/localeinfo.c:33:1: warning: data definition has no type or storage 
> class
>  static_assert (MB_LEN_MAX <= SCHAR_MAX);
>  ^~~~~~~~~~~~~
> ../../lib/localeinfo.c:33:1: warning: type defaults to 'int' in declaration 
> of 'static_assert' [-Wimplicit-int]
> ../../lib/localeinfo.c:125:38: error: macro "static_assert" requires 2 
> arguments, but only 1 given
>                 <= CASE_FOLDED_BUFSIZE);
>                                       ^
> ../../lib/localeinfo.c:124:1: warning: data definition has no type or storage 
> class
>  static_assert (1 + 1 + sizeof lonesome_lower / sizeof *lonesome_lower
>  ^~~~~~~~~~~~~
> ../../lib/localeinfo.c:124:1: warning: type defaults to 'int' in declaration 
> of 'static_assert' [-Wimplicit-int]
> gmake[3]: *** [Makefile:2993: libgreputils_a-localeinfo.o] Error 1
>
>
> The fix has already been committed in Gnulib:
> https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=0814a293a4e40e49a8a0d2d5d94f04cc170a7e2a
>
> You thus only need to use a newer Gnulib version (or one of the stable
> branches).
>
> Other than that, the compilation then succeeds and all tests pass.

Thanks for exposing and fixing that.
I'll be sure to update to new enough gnulib before the release.