groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 22/31: [mm]: Tweak diagnostic handling.


From: G. Branden Robinson
Subject: [groff] 22/31: [mm]: Tweak diagnostic handling.
Date: Wed, 17 Aug 2022 01:26:06 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit bd06e20cd9692b427293619843a0623e49c37689
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sun Aug 14 22:25:08 2022 -0500

    [mm]: Tweak diagnostic handling.
    
    * contrib/mm/m.tmac (@warning, @error): Stop pointlessly using no-break
      control character when invoking the `tm` request, which never
      causes a break in formatted output.  (Management of the standard
      output and standard error streams is the user's responsibility.)
    
      (@error): Drop old-fashioned asterisk banners around error
      diagnostics.  Stop invoking `ab` with redundant and sometimes
      misleading arguments.  In groff 1.23, `ab` exits silently if given
      none.  We've already issued a diagnostic and moreover not all problems
      are with "syntax"; some are semantic.
---
 contrib/mm/ChangeLog | 12 ++++++++++++
 contrib/mm/m.tmac    |  9 ++++-----
 2 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/contrib/mm/ChangeLog b/contrib/mm/ChangeLog
index 1e58d80e9..9c996bc5d 100644
--- a/contrib/mm/ChangeLog
+++ b/contrib/mm/ChangeLog
@@ -1,3 +1,15 @@
+2022-08-14  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       * m.tmac (@warning, @error): Stop pointlessly using no-break
+       control character when invoking the `tm` request, which never
+       causes a break in formatted output.  (Management of the standard
+       output and standard error streams is the user's responsibility.)
+       (@error): Drop old-fashioned asterisk banners around error
+       diagnostics.  Stop invoking `ab` with redundant and sometimes
+       misleading arguments.  In groff 1.23, `ab` exits silently if
+       given none.  We've already issued a diagnostic and moreover not
+       all problems are with "syntax"; some are semantic.
+
 2022-08-14  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * m.tmac (PS): Validate better; check for 2 arguments exactly.
diff --git a/contrib/mm/m.tmac b/contrib/mm/m.tmac
index e642b9a3c..b024e22e4 100644
--- a/contrib/mm/m.tmac
+++ b/contrib/mm/m.tmac
@@ -390,15 +390,14 @@ Index             array!index
 .vs \\n[@vs]u
 ..
 .de @warning
-'tm \\*[@mm]:\\n[.F]:\\n[.c]: warning: \\$*
+.tm \\*[@mm]:\\n[.F]:\\n[.c]: warning: \\$*
 .if \\n[D] .backtrace
 ..
+.\" All errors are fatal.
 .de @error
-'tm ******************
-'tm \\*[@mm]:\\n[.F]:\\n[.c]: error: \\$*
+.tm \\*[@mm]:\\n[.F]:\\n[.c]: error: \\$*
 .if \\n[D] .backtrace
-'tm ******************
-.ab \\*[@mm]: syntax error; aborting
+.ab
 ..
 .de misc@toupper
 .tr aAbBcCdDeEfFgGhHiIjJkKlLmMnNoOpPqQrRsStTuUvVwWxXyYzZ



reply via email to

[Prev in Thread] Current Thread [Next in Thread]