Re: bugfix, hostfs

[Marco Gerards]

address@hidden (Tomas Ebenlendr) writes:

>> This requires some changes in the cache manager, but not difficult. What 
>> do you think?
>
> Hmm, leaving this change for anybody who understand disks in grub.
> Instead of it I use disk->name :-) .

Better use an int.  It is easier/cheaper to check and IMHO cleaner.

> PS.: I'm changing conf/powerpc-ieee1275.rmk and I didn't test
>   compilability of my code on ppc. But it should be OS-dependent, but
>   not architecture dependent.

Don't worry about that.  This only changes stuff in util/, so no bad
things will happen.  BTW, I see you have added hostfs.c to fs/, I
think util/ is a better place for this.

> ##########################################################################
> Changelog:
> 2004-08-08  Tomas Ebenlendr  <address@hidden>
>
>       * kern/dl.c (grub_dl_load_file): Fixed bug: When
>       grub_dl_load_core fails, mod shouldn't be derefered.

Just leave "Fixed bug: " away.  If Okuji says it is ok to commit,
please change the date to the commit date.

> +      case ENOMEM: r = GRUB_ERR_OUT_OF_MEMORY; break;
> +      case ENOTDIR:
> +      case ENOENT: r = GRUB_ERR_FILE_NOT_FOUND; break;
> +      case ELOOP: r = GRUB_ERR_SYMLINK_LOOP; break;
> +      case EIO: r = GRUB_ERR_FILE_READ_ERROR; break;
> +      default: r = GRUB_ERR_BAD_ARGUMENT; break;

I think I missed this last time.  Better use multiple lines for a case
statement.

> +  file->data = (void *) open(name, O_RDONLY);

open (

> +    return errno2err();

You missed a space here as well.

> +    return errno2err();

...

Thanks,
Marco