Re: [PATCH] Framebuffer ieee1275 support & test commands

[Hollis Blanchard]

On Aug 25, 2005, at 5:19 AM, Vincent Pelletier wrote:
> Here is my patch to add support for framebuffer on IEEE1275 machines, a
> fractal drawing test program, and a mouse test program.

No time for real review at the moment, but:
- you spelled "Manldebrot" wrong in the first comment
- you have lots of commented-out code present
- what is this "GRUB_EMBED" stuff?
- mouse support should be a separate patch from framebuffer support
- the "XXX Test me!" code should either be tested or removed
- I'm unclear on your distinction between "fb" and "fbprops" in file 
names.

In general I'd say this patch is not yet ready for merging.

What is your model for framebuffer drivers in general (including across 
architectures)? For example, every fb driver will provide what API, and 
should that be used by common code?

-Hollis