[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] split realmode and loader routines out of startup.S
From: |
Marco Gerards |
Subject: |
Re: [PATCH] split realmode and loader routines out of startup.S |
Date: |
Wed, 17 Oct 2007 12:35:03 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Robert Millan <address@hidden> writes:
> On Wed, Oct 17, 2007 at 12:04:14PM +0200, Marco Gerards wrote:
>> >
>> > Linking required wrapping a lot of references with EXT_C() macro, so I
>> > opted
>> > for #include (note this is done for lzo1x.S already).
>>
>> Is using EXT_C a problem? I don't know this code too well,
>> unfortunately :(
>
> No. Maybe linking bring in other problems, but EXT_C per se isn't a big deal.
> Though do we really want it? It doesn't seem to be a problem for lzo1x.S.
Including is not a big problem for me. It should just not become a
common practise. It's easy to change so I am fine with it.
--
Marco