grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Compiling grub2 on *BSD?


From: Bean
Subject: Re: Compiling grub2 on *BSD?
Date: Tue, 29 Jan 2008 19:00:10 +0800

On Jan 28, 2008 8:56 PM, Marco Gerards <address@hidden> wrote:
> Robert Millan <address@hidden> writes:
>
> >> > -       movsbl  %dh, %eax
> >> > -       movl    %eax, %ss:(DATA_ADDR + 
> >> > GRUB_KERNEL_MACHINE_INSTALL_DOS_PART)
> >> > +       // Check for the multiboot signature
> >> > +       cmpl    $0x1badb002, %ss:(DATA_ADDR + 0x50)
> >> > +       jz      1f
> >> [...]
> >>
> >> if there is no objection, I'd like to check in this patch.
> >
> > I don't like that you hardcode 0x1badb002.  Could you use the macro from
> > multiboot.h ?
> >
> > Also for the comments, I think /* */ is preferred (at least, it is 
> > consistent
> > with the rest of GRUB).
>
> And do not forget "." :-)

Fixed and committed.

-- 
Bean




reply via email to

[Prev in Thread] Current Thread [Next in Thread]