Re: Please support installation on Xen virtual block devices

[Robert Millan]

On Tue, May 06, 2008 at 05:33:23PM -0400, Pavel Roskin wrote:
> On Tue, 2008-05-06 at 16:29 +0100, Ian Campbell wrote:
> > Any comments on this patch?
> 
> It's basically OK, bug please provide the GNU style ChangeLog entry.
> The second part of the patch doesn't need preprocessor conditionals
> because it's already compiled for Linux only.  Please use tabs for
> indentation rather than 8 spaces.  The innermost block is indented two
> spaces too far.

Ian, it looks like you copied this style from existing code.  Is that so?

In that case, I don't think the indentation issue concerns your patch (if we
have to fix indentation, we could just do it in the whole file).

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)