grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pc & gpt partmap iterators don't abort when their hook reque


From: Robert Millan
Subject: Re: [PATCH] pc & gpt partmap iterators don't abort when their hook requests it
Date: Tue, 1 Jul 2008 17:33:37 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

On Tue, Jul 01, 2008 at 03:25:32PM +0200, Robert Millan wrote:
> 
> See ChangeLog for description.  I'd really like to receive some review on
> this one, since the code it touches is so fragile (although I tested it on a
> typical setup and it works).

Tough luck.  Inmediately after this I noticed it breaks grub-setup (I tested it
by loading core.img directly).

I found a few other callers that relied on the buggy behaviour.  Here's a new
patch.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)

Attachment: partmap_iterator_abortion.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]