[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] unused constants in i386/boot.h
|
From: |
Robert Millan |
|
Subject: |
Re: [PATCH] unused constants in i386/boot.h |
|
Date: |
Tue, 14 Jul 2009 19:37:06 +0200 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote:
> Quoting Yves Blusseau <address@hidden>:
>
>>> As long as boot/i386/pc/boot.S has the variables whose offset these macros
>>> are describing, I think it's fine to keep them.
>
> I'd rather not keep the macros that are not used outside boot.S. They
> give a wrong impression that somebody somewhere needs to know that
> offset.
Ok, let's remove them. I don't feel strongly about it.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."