Re: [PATCH] xfs bug fix

[Bean]

On Sun, Jul 19, 2009 at 12:40 PM, Pavel Roskin<address@hidden> wrote:
> Quoting Pavel Roskin <address@hidden>:
>
>> ==11029== Conditional jump or move depends on uninitialised value(s)
>> ==11029==    at 0x403CAE: grub_disk_adjust_range (disk.c:373)
>> ==11029==    by 0x403D6C: grub_disk_read (disk.c:392)
>> ==11029==    by 0x41CB8C: grub_xfs_read_inode (xfs.c:222)
>
> P.S. It looks like struct grub_xfs_inode hardcodes size 256, so every use of
> sizeof (struct grub_xfs_inode) is suspicious.  Likewise, struct
> grub_fshelp_node and struct grub_xfs_data should not be used blindly with
> sizeof.

Hi,

Oh nice catch, it's indeed a serious problem, this patch should fix it.

-- 
Bean

xfs_2.diff
Description: Text Data